Fixes to SMTP backend #309

matzipan · 2023-10-02T23:07:49+03:00

matzipan commented

2023-10-02 23:07:49 +03:00

Summary of the PR

Fixes #307, #308

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality, especially configuration options, are documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

### Summary of the PR Fixes #307, #308 ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [x] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [x] All added/changed public-facing functionality, especially configuration options, are documented in the manual pages. * [x] Any newly added `unsafe` code is properly documented. * [x] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [x] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [x] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

matzipan added 3 commits 2023-10-02 23:07:49 +03:00

7aec5b8e78 Fix SMTP example doc

Signed-off-by: Andrei Zisu <matzipan@gmail.com>

3105a0373b Add quit command

Signed-off-by: Andrei Zisu <matzipan@gmail.com>

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (push) Successful in 20m52s Details

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 21m18s Details

e95c275d68 Remove duplicate end sequence

Signed-off-by: Andrei Zisu <matzipan@gmail.com>

matzipan changed title from ~~WIP:~~ to Fixes to SMTP backend

2023-10-02 23:08:09 +03:00

Manos Pitsidianakis merged commit e95c275d68 into master

2023-10-03 10:10:17 +03:00

Manos Pitsidianakis commented

2023-10-03 10:12:00 +03:00

Excellent, I added you as a maintainer so you can merge stuff directly or work directly on this repository instead of forks if you wish.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: meli/meli#309