Add Newsgroups field when composing NNTP articles #305

Manos Pitsidianakis · 2023-09-23T18:54:57+03:00

Manos Pitsidianakis commented

2023-09-23 18:54:57 +03:00

Fixes #267

Summary of the PR

This PR adds:

an extra_submission_headers field in mail backend capabilities so that if a backend requires extra headers, they can specify it there. Now only NNTP uses it.
the frontend composer widget uses the previous information for populating the header form with the extra headers, if any.

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality, especially configuration options, are documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

Fixes #267 ### Summary of the PR This PR adds: - an `extra_submission_headers` field in mail backend capabilities so that if a backend requires extra headers, they can specify it there. Now only NNTP uses it. - the frontend composer widget uses the previous information for populating the header form with the extra headers, if any.  ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [x] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [x] All added/changed public-facing functionality, especially configuration options, are documented in the manual pages. * [x] Any newly added `unsafe` code is properly documented. * [x] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [x] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [x] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

Manos Pitsidianakis added 2 commits 2023-09-23 18:54:58 +03:00

e88957ae6e

melib/backends: add extra_submission_headers field in MailBackendCapabilities struct

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 10m32s Details

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (push) Successful in 10m14s Details

d3cbf184e6

compose: add extra_submission_headers fields in composer form and autocomplete for Newsgroups

Submitting to NNTP/Usenet servers requires you to specify which news
groups the post/article is going to. This commit places all
extra_submission_headers from a backend (in this case only NNTP
implements this) in the composing form fields.

Fixes #267

nntp should add Newsgroups header if missing
<https://git.meli.delivery/meli/meli/issues/267>

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis merged commit d3cbf184e6 into master

2023-09-23 19:11:59 +03:00

Manos Pitsidianakis deleted branch feature/add-nntp-newsgroups-header

2023-09-23 19:11:59 +03:00

Sign in to join this conversation.

No reviewers