melib/datetime: add timestamp_to_string_utc #253

Manos Pitsidianakis · 2023-07-09T18:52:11+03:00

2023-07-09 18:52:11 +03:00

Tests were using timestamp_to_string which in turn uses localtime_r
which assumes the local machine's time zone. Use gmtime_r instead.

Fixes #252

Tests were using `timestamp_to_string` which in turn uses `localtime_r` which assumes the local machine's time zone. Use gmtime_r instead. Fixes #252

Manos Pitsidianakis added 1 commit 2023-07-09 18:52:12 +03:00

d93ee413a7

melib/datetime: add timestamp_to_string_utc

Tests were using `timestamp_to_string` which in turn uses `localtime_r`
which assumes the local machine's time zone. Use gmtime_r instead.

Fixes #252

r3k2 commented

2023-07-09 19:49:43 +03:00

I did not test the AUR package but I cloned the repo and pulled this pr and so far seems like it work


test result: ok. 25 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.24s

   Doc-tests melib

running 22 tests
test src/backends.rs - backends::BackendOp (line 459) ... ignored
test src/backends.rs - backends::BackendOp (line 466) ... ignored
test src/backends/mbox.rs - backends::mbox (line 102) - compile ... ok
test src/email/headers/names.rs - email::headers::names::HeaderName::eq (line 734) ... ok
test src/email/address.rs - email::address::Address (line 94) ... ok
test src/thread.rs - thread::SubjectPrefix (line 200) ... ok
test src/email/headers/names.rs - email::headers::names::str::eq (line 753) ... ok
test src/text_processing/line_break.rs - text_processing::line_break::LineBreakCandidateIter<'a> (line 136) ... ok
test src/utils/parsec.rs - utils::parsec::alt (line 443) ... ok
test src/search.rs - search::query_parser::query (line 370) ... ok
test src/email/address.rs - email::address::Address::subaddress (line 257) ... ok
test src/email.rs - email (line 30) ... ok
test src/utils/datetime.rs - utils::datetime (line 26) ... ok
test src/backends/mbox.rs - backends::mbox (line 83) ... ok
test src/utils/percent_encoding.rs - utils::percent_encoding::AsciiSet (line 60) ... ok
test src/email/address.rs - email::address::Address (line 83) ... ok
test src/utils/parsec.rs - utils::parsec::take_literal (line 580) ... ok
test src/utils/percent_encoding.rs - utils::percent_encoding (line 32) ... ok
test src/utils/percent_encoding.rs - utils::percent_encoding::percent_decode (line 367) ... ok
test src/utils/percent_encoding.rs - utils::percent_encoding::percent_encode (line 232) ... ok
test src/utils/percent_encoding.rs - utils::percent_encoding::percent_encode_byte (line 180) ... ok
test src/utils/percent_encoding.rs - utils::percent_encoding::utf8_percent_encode (line 257) ... ok

test result: ok. 20 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 7.58s

Thanks. @epilys

I did not test the AUR package but I cloned the repo and pulled this pr and so far seems like it work ``` test result: ok. 25 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.24s Doc-tests melib running 22 tests test src/backends.rs - backends::BackendOp (line 459) ... ignored test src/backends.rs - backends::BackendOp (line 466) ... ignored test src/backends/mbox.rs - backends::mbox (line 102) - compile ... ok test src/email/headers/names.rs - email::headers::names::HeaderName::eq (line 734) ... ok test src/email/address.rs - email::address::Address (line 94) ... ok test src/thread.rs - thread::SubjectPrefix (line 200) ... ok test src/email/headers/names.rs - email::headers::names::str::eq (line 753) ... ok test src/text_processing/line_break.rs - text_processing::line_break::LineBreakCandidateIter<'a> (line 136) ... ok test src/utils/parsec.rs - utils::parsec::alt (line 443) ... ok test src/search.rs - search::query_parser::query (line 370) ... ok test src/email/address.rs - email::address::Address::subaddress (line 257) ... ok test src/email.rs - email (line 30) ... ok test src/utils/datetime.rs - utils::datetime (line 26) ... ok test src/backends/mbox.rs - backends::mbox (line 83) ... ok test src/utils/percent_encoding.rs - utils::percent_encoding::AsciiSet (line 60) ... ok test src/email/address.rs - email::address::Address (line 83) ... ok test src/utils/parsec.rs - utils::parsec::take_literal (line 580) ... ok test src/utils/percent_encoding.rs - utils::percent_encoding (line 32) ... ok test src/utils/percent_encoding.rs - utils::percent_encoding::percent_decode (line 367) ... ok test src/utils/percent_encoding.rs - utils::percent_encoding::percent_encode (line 232) ... ok test src/utils/percent_encoding.rs - utils::percent_encoding::percent_encode_byte (line 180) ... ok test src/utils/percent_encoding.rs - utils::percent_encoding::utf8_percent_encode (line 257) ... ok test result: ok. 20 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 7.58s ``` Thanks. @epilys

Manos Pitsidianakis merged commit d93ee413a7 into master

2023-07-09 23:17:15 +03:00

Manos Pitsidianakis deleted branch fix/252-localtime-gmtime

2023-07-09 23:17:15 +03:00

Sign in to join this conversation.

No reviewers