Feature Request: Support tilde (~) in vcard_folder option #387

New Issue

iooioio · 2024-05-05T23:35:31+03:00

iooioio commented

2024-05-05 23:35:31 +03:00

Thank you for fixing #349. In a brief test I noticed that using ~ to refer to my home folder is not supported. That was surprising because it does work for the root_mailbox option.

It would be nice (and more consistent) to have support for tilde expansion in all options that accept a path.

Thank you for fixing #349. In a brief test I noticed that using `~` to refer to my home folder is not supported. That was surprising because it _does_ work for the `root_mailbox` option. It would be nice (and more consistent) to have support for tilde expansion in all options that accept a path.

Manos Pitsidianakis commented

2024-05-06 10:03:36 +03:00

Thank you for reporting this! Indeed the paths are not handled the same way. There's a helper tool to "expand" tildes etc in paths in melib/src/utils/shellexpand.rs which is used for mail backend root_mailbox paths but not in vcard folder paths. All user configuration paths should have .expand() called on them before trying access.

Thank you for reporting this! Indeed the paths are not handled the same way. There's a helper tool to "expand" tildes etc in paths in `melib/src/utils/shellexpand.rs` which is used for mail backend root_mailbox paths but not in vcard folder paths. All user configuration paths should have `.expand()` called on them before trying access.

Manos Pitsidianakis added the

bug

label 2024-05-06 10:03:41 +03:00

Manos Pitsidianakis referenced this issue from a commit

2024-05-06 14:37:33 +03:00

Use ShellExpandTrait::expand in more user-provided paths

Manos Pitsidianakis referenced this issue from a commit

2024-05-06 18:36:21 +03:00

Use ShellExpandTrait::expand in more user-provided paths

Manos Pitsidianakis closed this issue

2024-05-06 19:19:54 +03:00

Sign in to join this conversation.