accounts: add default_mailbox setting #370

Manos Pitsidianakis · 2024-03-16T18:17:35+02:00

2024-03-16 18:17:35 +02:00

Summary of the PR

Add a default mailbox setting:

The mailbox that is the default to open / view for this account. Must be
a valid mailbox name.

If not specified, the default is [Self::root_mailbox].

Closes: #350

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality, especially configuration options, are documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

### Summary of the PR Add a default mailbox setting: > The mailbox that is the default to open / view for this account. Must be > a valid mailbox name. > > If not specified, the default is [`Self::root_mailbox`]. Closes: #350 ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [x] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [x] All added/changed public-facing functionality, especially configuration options, are documented in the manual pages. * [x] Any newly added `unsafe` code is properly documented. * [x] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [x] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [x] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

Manos Pitsidianakis added 7 commits 2024-03-16 18:17:36 +02:00

8014af2563

imap/protocol_parser: reduce debug prints

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

f31b5c4000

melib/connections: don't print raw bytes as escaped unicode

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

41e965b8a3

meli/accounts: split mbox/job stuff in submodules

accounts.rs is getting rather long (almost 3K lines) so split standalone
stuff in submodules.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

264782d228

Various unimportant minor style/doc fixups

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

484712b0c3

accounts: check for unrecoverable errors in is_online

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

742f038f74

accounts: move sent_mailbox to settings

In the next commits we will add a `default_mailbox` field. Instead of
poluting the `Account` struct with more setting fields, consolidate them
on its `settings`.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Run cargo lints / Lint on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 8m28s Details

Run Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 13m30s Details

4e941a9e8b

accounts: add default_mailbox setting

Add a default mailbox setting:

> The mailbox that is the default to open / view for this account. Must be
> a valid mailbox name.
>
> If not specified, the default is [`Self::root_mailbox`].

Closes: #350
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis referenced this pull request

2024-03-16 18:19:02 +02:00

Allow root_mailbox and default mailbox to be different #350

Manos Pitsidianakis merged commit 4e941a9e8b into master

2024-03-16 18:36:14 +02:00

Manos Pitsidianakis deleted branch default-mailbox

2024-03-16 18:36:15 +02:00

Sign in to join this conversation.

No reviewers