nntp fails to download big groups and when adding many groups will also fail to load any of them #269

New Issue

r3k2 · 2023-08-01T19:39:08+03:00

r3k2 commented

2023-08-01 19:39:08 +03:00

Two similar issues I noticed this last days that may be related in the way news are pulled from the server:

I have one group that will never finish loading group articles/news if you want to test is news.software.nntp
I decided to add some of the groups I usually read/post every day and now will not load,
I get a on-moving msg like this below in grey but I left it like 2 hours while I was out and never finished loading any of the groups (I changed the numbers a bit just in case )

<<scrolls<-- 8d1dc2f-8ea7-472b-aabf-1b7a77d0682a <<--scrolls: JobRequest::Mailboxes

we are talking about around 23 active usenet groups, I usually subscribe to around 38 give or take.

Two similar issues I noticed this last days that may be related in the way news are pulled from the server: - I have one group that will never finish loading group articles/news if you want to test is news.software.nntp - I decided to add some of the groups I usually read/post every day and now will not load, I get a on-moving msg like this below in grey but I left it like 2 hours while I was out and never finished loading any of the groups (I changed the numbers a bit just in case ) ``` <<scrolls<-- 8d1dc2f-8ea7-472b-aabf-1b7a77d0682a <<--scrolls: JobRequest::Mailboxes ``` we are talking about around 23 active usenet groups, I usually subscribe to around 38 give or take.

Manos Pitsidianakis referenced this issue from a commit

2023-08-05 16:18:18 +03:00

melib/nntp: accept invalid (non-ascii) address comment text

Manos Pitsidianakis referenced a pull request that will close this issue

2023-08-05 16:18:30 +03:00

melib/nntp: accept invalid (non-ascii) address comment text #270

Manos Pitsidianakis commented

2023-08-05 16:19:39 +03:00

@r3k2 Thanks for the bug report, I tried news.software.nntp and I got the same problem as you. Turns out it was an infinite loop in the From: address parsing. I have made a PR but haven't merged it yet, in case there are still groups not loading for you.

@r3k2 Thanks for the bug report, I tried `news.software.nntp` and I got the same problem as you. Turns out it was an infinite loop in the From: address parsing. I have made a PR but haven't merged it yet, in case there are still groups not loading for you.

Manos Pitsidianakis added the

bug

label 2023-08-05 16:19:43 +03:00

r3k2 commented

2023-08-07 05:37:51 +03:00

Poster

@epilys you fixed the issue with news.software.nntp but the one related to having more groups like 20 or so of them is still and issue.

Manos Pitsidianakis referenced this issue from a commit

2023-08-07 11:44:00 +03:00

melib/nntp: limit LIST ACTIVE command length to 512 octets

Manos Pitsidianakis commented

2023-08-07 11:45:18 +03:00

@r3k2 turns out because the mailbox was too big it exceeded the NNTP max limit of command length (512 bytes) which was not taken into account before. I fixed the faulty command and also added an error warning if any other command does that in the future as well.

r3k2 commented

2023-08-07 21:06:49 +03:00

Poster

@epilys As I commented in the PR, I think this is working great now. Thanks so much, hopefully it hits master soon and with the header adding thing should be fully usable as a newsreader.

Manos Pitsidianakis referenced this issue from a commit

2023-08-10 18:38:26 +03:00

melib/nntp: accept invalid (non-ascii) address comment text

Manos Pitsidianakis referenced this issue from a commit

2023-08-10 18:38:26 +03:00

melib/nntp: limit LIST ACTIVE command length to 512 octets

Manos Pitsidianakis closed this issue

2023-08-10 18:38:48 +03:00

Sign in to join this conversation.