tracking: Integrate imap-codec. #222

New Issue

duesee · 2023-05-30T12:28:16+03:00

duesee commented

2023-05-30 12:28:16 +03:00

Leaving this issue here so that we have something to reference in the code.

These are some things we still need to do:

Sending commands.
- Replace remaining send_command_raw(&[u8]) instances.
  - Some instances can not be changed until imap-codec supports the relevant IMAP capability, i.e..,
    - LIST \"{}\" \"\" RETURN (STATUS (MESSAGES UNSEEN))
    - (CHANGEDSINCE {})
  - Some instances can already be refactored but I need to understand what the code should do in the first place :-)
Receiving responses.
- Unify types ...
  - Query (meli) vs SearchKey (imap-codec)
  - Envelope (meli) vs Envelope (imap-codec)
  - Flag (meli) vs Flag (imap-codec)
  - ...
- Replace read_response.

Leaving this issue here so that we have something to reference in the code. These are some things we still need to do: * Sending commands. * [ ] Replace remaining `send_command_raw(&[u8])` instances. * Some instances can not be changed until imap-codec supports the relevant IMAP capability, i.e.., * `LIST \"{}\" \"\" RETURN (STATUS (MESSAGES UNSEEN))` * `(CHANGEDSINCE {})` * Some instances can already be refactored but I need to understand what the code should do in the first place :-) * Receiving responses. * [ ] Unify types ... * `Query` (meli) vs `SearchKey` (imap-codec) * `Envelope` (meli) vs `Envelope` (imap-codec) * `Flag` (meli) vs `Flag` (imap-codec) * ... * Replace `read_response`.

Manos Pitsidianakis commented

2023-06-23 21:42:11 +03:00

@duesee what remains of this task now that IMAP requests are merged?

duesee commented

2023-06-23 22:14:19 +03:00

Poster

A bit from everything :-) I planed to proceed with response handling early next week.

Most items above are bound to response handling, i.e., Query, Envelope, read_response. But there are some better APIs that we can also use to make the last imap-codec PR nicer.

I'll update this issue as I go.

A bit from everything :-) I planed to proceed with response handling early next week. Most items above are bound to response handling, i.e., `Query`, `Envelope`, `read_response`. But there are some better APIs that we can also use to make the last imap-codec PR nicer. I'll update this issue as I go.

Manos Pitsidianakis added the

IMAP

label 2023-07-02 18:38:10 +03:00

Manos Pitsidianakis added this to the Integrate imap-codec into IMAP backend project 2023-07-02 18:39:38 +03:00

Manos Pitsidianakis referenced this issue from a commit

2023-07-05 16:18:53 +03:00

docs: Add some `TODO(#222)`s.

Manos Pitsidianakis pinned this 2023-07-24 11:54:21 +03:00

Sign in to join this conversation.